PR #838 review (sonnet): merge after four small fixes
From mnema-talk v3.3.13, rendered on this site.
Reviewer: a sonnet agent, read-only, given the PR number and the focus (the one Link active switch for the vanity link, the inactive page) and nothing else. It ran no tests. The diff was written by an agent (Gemini through agy) and read in full by the author before the review.
FINDINGS
- should-fix:
SECURITY.mdstill named Let this link create accounts. Fixed: it says Link active and "not active" page. - should-fix:
e2e/tests/vanity-link.spec.tsdid not wait for the second save before the visitor reloaded, so it could race. Fixed: it waits for the save bar to go idle. - should-fix: the same spec failed on a second run against the same database, because a stored link stops the new-link default. Fixed: it removes the link in a
finally. - note: the German assertion on the inactive page compared a 12 character prefix. Fixed: it compares the whole locale string.
- note:
InviteInactive.vuecarried afocus:outline-hiddenclass on an element that cannot take focus. Removed. There is no<main>landmark; left as it is, like the login dialog.
CHECKED AND FINE
AdminVanityLink.vue: a new link starts on only for the Owner; an Administrator never gets the switch on, and the value sent is still forced off when an Administrator renames an active link.InviteLanding.vue: an unknown name and an API error both show the plain login dialog and nothing about the name; an inactive link shows only the inactive page, which carries no community name.LoginModal.vuestill falls back to asking for a code when a link is switched off between page load and submit.- No migration and no API change:
accepts_signupskeeps its name and meaning, so older desktop bundles and the compat baselines are unaffected; rows with sign-ups off already read as inactive. - EN and DE have the same keys; the removed ones have no remaining references.